tui: plumb permission profile selection#23708
Merged
Merged
Conversation
This was referenced May 20, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13bae1d6ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
viyatb-oai
force-pushed
the
codex/viyatb/profile-permissions-runtime
branch
from
e0764d3 to
923b79d
Compare
viyatb-oai
force-pushed
the
codex/viyatb/tui-permission-profile-selection
branch
from
ce7ae38 to
ef21b6b
Compare
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
viyatb-oai
force-pushed
the
codex/viyatb/profile-permissions-runtime
branch
from
923b79d to
9badcc1
Compare
viyatb-oai
force-pushed
the
codex/viyatb/tui-permission-profile-selection
branch
from
ef21b6b to
8e8150c
Compare
Co-authored-by: Codex noreply@openai.com
viyatb-oai
force-pushed
the
codex/viyatb/tui-permission-profile-selection
branch
from
8e8150c to
c83b8db
Compare
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
viyatb-oai
force-pushed
the
codex/viyatb/tui-permission-profile-selection
branch
from
c83b8db to
3ee4233
Compare
viyatb-oai
added a commit
that referenced
this pull request
May 20, 2026
## Why Once a named permission profile is selected, runtime state has to keep that profile identity intact instead of collapsing back to anonymous effective permissions. The session refresh path also needs to rebuild profile-derived network proxy state so active profile switches take effect consistently. ## What changed - Preserve the active permission profile through session updates. - Rebuild profile-derived runtime/network configuration when the active profile changes. - Keep the runtime path aligned with the current session configuration APIs. - Tighten the affected tests, including the Windows delete-pending memory-file case that was intermittently tripping CI. ## Stack 1. **This PR**: runtime/session/network propagation for active permission profiles. 2. [#23708](#23708): TUI selection plumbing and guardrail flow. 3. [#21559](#21559): profile-aware `/permissions` menu and custom profile display. <img width="1296" height="906" alt="image" src="https://github.com/user-attachments/assets/077fa3a7-80cb-4925-80b1-d2395018d90a" />
Co-authored-by: Codex noreply@openai.com
fcoury-oai
approved these changes
May 21, 2026
Contributor
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
Looks good, approved 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The named-profile
/permissionspicker needs a small TUI action path that can select permission profiles without folding the menu UI and profile metadata into the same review.What changed
/permissionspicker behavior in this layer; the profile-mode menu stays in the follow-up PR.Stack
/permissionsmenu and custom profile display.Validation
git diff --cached --checkbefore commit.